Jump to content

Sargasso Test Run


DZComposer

Recommended Posts

I have set Sargasso to the forum default temporarily to get some feedback. Please be on the lookout for anything that isn't right. Also if you don't like the way something looks let me know (within reason). Also, if you have any suggestions I would like to hear them.

Note that this theme is still a Work In Progress. I will be reverting the default back to Black Rain tomorrow evening.

The banner is temporary.

Link to comment
Share on other sites

The S on the banner is covered.

If you see it, tell me.

I see it too, its not just you.

My suggestion would be to make the navigation bar a tad bit bigger. Its kinda hard to see compared to the one in Black Rain.

P.S. I HAVE REACHED 1000 POSTS BABY!!!!!!!!!!!! I'M A LIEUTENANT NOW!!! WOOT!!!

Link to comment
Share on other sites

I see it too, its not just you.

My suggestion would be to make the navigation bar a tad bit bigger. Its kinda hard to see compared to the one in Black Rain.

P.S. I HAVE REACHED 1000 POSTS BABY!!!!!!!!!!!! I'M A LIEUTENANT NOW!!! WOOT!!!

CONGRATZ STAR FOX RUNNER!!!!

:fox::falco::peppy::slippy::krystal::wolf::leon::panther::dash::bill::katt:

:P

************************

Anyway, why was the site have to be like, slow? Then, few minutes later, the link was broken.

I tried emailing you DZ, but....

Link to comment
Share on other sites

I like it too. But the "forums" part of the banner is going offscreen. (At least on my side.) It just says "Fo".

Link to comment
Share on other sites

I like it too. But the "forums" part of the banner is going offscreen. (At least on my side.) It just says "Fo".

yeah it does that for me too
Link to comment
Share on other sites

Fixed the top image.

Update:

It appears, this theme... has a css flaw based on float issues. STUPID! ARGH! STUPID!

Sorry. I need to make my own theme at some point.

Link to comment
Share on other sites

Guest Julius Quasar

I have set Sargasso to the forum default temporarily to get some feedback. Please be on the lookout for anything that isn't right. Also if you don't like the way something looks let me know (within reason). Also, if you have any suggestions I would like to hear them.

Note that this theme is still a Work In Progress. I will be reverting the default back to Black Rain tomorrow evening.

The banner is temporary.

It's so perfect...do you really have to change it back to the default theme tomorrow?  I wish you didn't :P

Link to comment
Share on other sites

It's so perfect...do you really have to change it back to the default theme tomorrow?  I wish you didn't :P

Like I said, I think you can keep this theme permanently man. Just go here: http://forums.starfox-online.net/index.php?action=theme;sa=pick;u=925;a6949efd3561=166e9e9c961e531859005fac157821f4

Link to comment
Share on other sites

Fixed the top image.

Update:

It appears, this theme... has a css flaw based on float issues. STUPID! ARGH! STUPID!

Sorry. I need to make my own theme at some point.

I didn't mess with the floats, so the flaws probably exist in Black Silk as well. That said, I am curious as to what they are. Also, which file(s) did you edit? That way I know to grab it off the FTP before making changes.

I'd say most of the SMF themes out there have CSS issues. When I was theme shopping, I had some that looked fine in IE, but horrible (or worse, broken) in firefox.

It also turned out that Black Silk has a problem with it's Display.template.php file that breaks a lot of the buttons in the admin panel and quick edit that are dependent on javascript. I had to hack-up a new one from the default theme's file to get Sargasso's buttons to work properly.

So, it is advisable NOT to use Black Silk as your theme, or things will be broken.

Link to comment
Share on other sites

Right now, it's looking good, both in IE and Firefox.

Have you established which banner you plan to use permanently yet?

Link to comment
Share on other sites

I didn't mess with the floats, so the flaws probably exist in Black Silk as well. That said, I am curious as to what they are. Also, which file(s) did you edit? That way I know to grab it off the FTP before making changes.

I'd say most of the SMF themes out there have CSS issues. When I was theme shopping, I had some that looked fine in IE, but horrible (or worse, broken) in firefox.

It also turned out that Black Silk has a problem with it's Display.template.php file that breaks a lot of the buttons in the admin panel and quick edit that are dependent on javascript. I had to hack-up a new one from the default theme's file to get Sargasso's buttons to work properly.

So, it is advisable NOT to use Black Silk as your theme, or things will be broken.

The flaw has to do with when you have a container that holds multiple elements (in this case, the profile on left and content of post on right). When the sig is placed in the post, they must be using clear:both, which rightly should push the sig past the end of whatever content is in the post. The problem is that because they didn't implement it right, the sig is now also pushed past the profile data, adding extra, purposeless space to the post.

I modified the Sargasso style.css, added two images to the images folder, and changed the index.template (whatever) to have the image in the logobox, instead of using a css rule for it.

Link to comment
Share on other sites

I must say that I like the new skin very much. I don't see anything that shows up wrong.

Link to comment
Share on other sites

Hmm... There is a clear:both on both the profile the sig areas. Though the profile appears to has it in the "after" pseudo-element, moving it into the class does nothing.

Display.template.php handles the creation of the thread page.

This is the area containing the sig, which SMF calls the "Moderator Bar." (It also includes the IP address, report and warning links, and the horizontal rule.)


<?php

echo '

					</div>

				</div>

				<div class="moderatorbar">

						<div class="smalltext floatleft" id="modified_', $message['id'], '">';



		// Show "« Last Edit: Time by Person »" if this post was edited.

		if ($settings['show_modify'] && !empty($message['modified']['name']))

			echo '

							&#171; <em>', $txt['last_edit'], ': ', $message['modified']['time'], ' ', $txt['by'], ' ', $message['modified']['name'], '</em> &#187;';



		echo '

						</div>

						<div class="smalltext floatright">';



		// Maybe they want to report this post to the moderator(s)?

		if ($context['can_report_moderator'])

			echo '

							<a href="', $scripturl, '?action=reporttm;topic=', $context['current_topic'], '.', $message['counter'], ';msg=', $message['id'], '">', $txt['report_to_mod'], '</a> &nbsp;';



		// Can we issue a warning because of this post?  Remember, we can't give guests warnings.

		if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest'])

			echo '

							<a href="', $scripturl, '?action=profile;u=', $message['member']['id'], ';sa=issueWarning;msg=', $message['id'], '"><img src="', $settings['images_url'], '/warn.gif" alt="', $txt['issue_warning_post'], '" title="', $txt['issue_warning_post'], '" border="0" /></a>';

		echo '

							<img src="', $settings['images_url'], '/ip.gif" alt="" border="0" />';



		// Show the IP to this user for this post - because you can moderate?

		if ($context['can_moderate_forum'] && !empty($message['member']['ip']))

			echo '

							<a href="', $scripturl, '?action=trackip;searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqWin(this.href);" class="help">(?)</a>';

		// Or, should we show it because this is you?

		elseif ($message['can_see_ip'])

			echo '

							<a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqWin(this.href);" class="help">', $message['member']['ip'], '</a>';

		// Okay, are you at least logged in?  Then we can show something about why IPs are logged...

		elseif (!$context['user']['is_guest'])

			echo '

							<a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqWin(this.href);" class="help">', $txt['logged'], '</a>';

		// Otherwise, you see NOTHING!

		else

			echo '

							', $txt['logged'];



		echo '

						</div>';



		// Show the member's signature?

		if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled'])

			echo '

						<hr width="100%" size="1" style="clear: right;" class="margintop hrcolor" />

						<div class="signature">', $message['member']['signature'], '</div>';



		echo '

				</div>

			</div>';

			// the following <div> closes the post separator

			//echo'</div>';

		echo'</div>';

	}

?>



That commented div closure is something I have to remove from the file. A leftover from debugging.



I notice that the label for the code tag is black. I will add that to the "things to fix" list.



Here is the relevant CSS:



(from forum.css in the css folder):



.moderatorbar

{

	clear: both;

	margin-left: 16%;

}



(from style.css in the theme root):



.floatleft

{

	float: left;

}



/* Default font sizes: small (8pt), normal (10pt), and large (14pt). */

.smalltext

{

	font-size: 0.8em;

	font-family: verdana, sans-serif;

}







/* All the signatures used in the forum.  If your forum users use Mozilla, Opera, or Safari, you might add max-height here :lol:. */

.signature

{

	width: 100%;

	overflow: auto;

	padding-bottom: 3px;

	line-height: 1.3em;

}





The profile area has a class called "clearfix" applied to it:



/* Helping style to clear floated items. */

.clearfix:after 

{

	 content: "."; 

	 display: block; 

	 height: 0; 

	 clear: both; 

	 visibility: hidden;

}



.clearfix 

{

	display: inline-block;

}

[/code[

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
×
×
  • Create New...